Interesting, I am seeing about 20 agent get this repo command. I'll look at that later but first is the overwhelming install failures in the list.
In the install function we have a (IF) test that says
IF is ONLINE and Agent current running commands are < 2 then execute installer else log as a failure. Well its not a failure just not online or is already running other tasks and is busy.
This although accurate could log a friendlier message. So the 71 installing failures your seeing in log are most likely running commands over 2. I am making a modification to this in 2 ways. Number 1 will be to make message easier to understand as this is not a failure but a delay and we will add in why to log. (Agent is offline or agent is running excessive commands.) Number two is to add in a adjuster to the running commands so you can set that excessive value instead of hard coding it to the number 2. This will allow you to adjust the excessive count to any number you like allowing you to push past agents that maybe slower to execute commands. Although we do this test so we do not load down an agent that is already acting slow the number 2 maybe to strict a number for some MSPs that would otherwise allow more commands in queue.
So I do not think that the install failures are a plugin issue but an agent command queuing issue.
Here is the SQL query we use to see if agents are ready for installs
Code: Select all
SELECT a.ID,a.ClientID,a.ComputerID,c.LocationID,A.Application,a.Command,IF(c.LastContact > date_add(now(),interval -5 minute),'Yes','No') As Online, (SELECT COUNT(*) FROM commands WHERE Status > 3 and ComputerID = a.ComputerID) As RunningCMDs FROM plugin_p4l_chocolatey_commands a LEFT JOIN computers c on a.ComputerID = c.ComputerID Where ExecuteDate IS NULL;
If command = INSTALL then look at RunningCMDs number to see if it is 2 or more or if agent says Online = no
Any agent ID that reports either will be skipped and will be re run again later.
mmoyse wrote: ↑Tue Jun 08, 2021 2:42 pm
It returns 2796 which is the ID of the Automate server which is called Automate and does not appear in the list.